Use signals ont publication creation and update pages.

Dockerfile-frontend

@@ -7,6 +7,6 @@ RUN npm run build-prod-fr
 
 FROM nginx:1.27-alpine AS final
 WORKDIR /app
-COPY --from=builder /app/dist/codiki-ng/en/browser /usr/share/nginx/html/en/
+COPY --from=builder /app/dist/codiki/en/browser /usr/share/nginx/html/en/
-COPY --from=builder /app/dist/codiki-ng/fr/browser /usr/share/nginx/html/fr/
+COPY --from=builder /app/dist/codiki/fr/browser/fr /usr/share/nginx/html/fr/
 COPY frontend/conf/nginx.conf /etc/nginx/nginx.conf

frontend/angular.json

@@ -3,7 +3,7 @@
   "version": 1,
   "newProjectRoot": "projects",
   "projects": {
-    "codiki-ng": {
+    "codiki": {
       "projectType": "application",
       "schematics": {
         "@schematics/angular:component": {
@@ -14,16 +14,19 @@
       "sourceRoot": "src",
       "prefix": "app",
       "i18n": {
-        "sourceLocale": "en-UK",
+        "sourceLocale": "en",
         "locales": {
-          "fr": "src/locale/messages-fr.json"
+          "fr": {
+            "translation": "src/locale/messages-fr.json"
+          }
+          
         }
       },
       "architect": {
         "build": {
           "builder": "@angular-devkit/build-angular:application",
           "options": {
-            "outputPath": "dist/codiki-ng",
+            "outputPath": "dist/codiki",
             "index": "src/index.html",
             "browser": "src/main.ts",
             "polyfills": [
@@ -56,7 +59,7 @@
                 }
               ],
               "outputHashing": "all",
-              "outputPath": "dist/codiki-ng/en/"
+              "outputPath": "dist/codiki/en/"
             },
             "production-fr": {
               "budgets": [
@@ -71,8 +74,10 @@
                   "maximumError": "4kb"
                 }
               ],
+              "localize": ["fr"],
+              "i18nMissingTranslation": "error",
               "outputHashing": "all",
-              "outputPath": "dist/codiki-ng/fr/"
+              "outputPath": "dist/codiki/fr/"
             },
             "development": {
               "optimization": false,
@@ -80,18 +85,18 @@
               "sourceMap": true
             },
             "en": {
-              "outputPath": "dist/codiki-ng/en/",
+              "outputPath": "dist/codiki/en/",
               "optimization": false,
               "extractLicenses": false,
               "sourceMap": true
             },
             "fr": {
-              "outputPath": "dist/codiki-ng/fr/",
+              "outputPath": "dist/codiki/fr/",
               "optimization": false,
               "extractLicenses": false,
               "sourceMap": true,
               "localize": ["fr"],
-              "i18nMissingTranslation": "error"
+              "i18nMissingTranslation": "warning"
             }
           },
           "defaultConfiguration": ""
@@ -100,19 +105,19 @@
           "builder": "@angular-devkit/build-angular:dev-server",
           "configurations": {
             "production-en": {
-              "buildTarget": "codiki-ng:build:production-en"
+              "buildTarget": "codiki:build:production-en"
             },
             "production-fr": {
-              "buildTarget": "codiki-ng:build:production-fr"
+              "buildTarget": "codiki:build:production-fr"
             },
             "development": {
-              "buildTarget": "codiki-ng:build:development"
+              "buildTarget": "codiki:build:development"
             },
             "en": {
-              "buildTarget": "codiki-ng:build:en"
+              "buildTarget": "codiki:build:en"
             },
             "fr": {
-              "buildTarget": "codiki-ng:build:fr"
+              "buildTarget": "codiki:build:fr"
             }
           },
           "defaultConfiguration": "development"
@@ -120,7 +125,7 @@
         "extract-i18n": {
           "builder": "@angular-devkit/build-angular:extract-i18n",
           "options": {
-            "buildTarget": "codiki-ng:build"
+            "buildTarget": "codiki:build"
           }
         },
         "test": {

frontend/package.json

@@ -8,7 +8,7 @@
     "start-fr": "ng serve --port 4201 --configuration=fr --proxy-config proxy.conf.json",
     "build": "ng build",
     "build-prod-en": "ng build --configuration=production-en --base-href /en/",
-    "build-prod-fr": "ng build --configuration=production-fr --base-href /fr/",
+    "build-prod-fr": "ng build --configuration=production-fr --base-href",
     "watch": "ng build --watch --configuration development",
     "test": "ng test",
     "i18n": "npm run i18n-ng-extraction && npm run i18n-fr-file-completion",
@@ -17,25 +17,25 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "^17.0.0",
+    "@angular/animations": "^18.2.5",
-    "@angular/cdk": "^17.3.1",
+    "@angular/cdk": "^18.2.5",
-    "@angular/common": "^17.0.0",
+    "@angular/common": "^18.2.5",
-    "@angular/compiler": "^17.0.0",
+    "@angular/compiler": "^18.2.5",
-    "@angular/core": "^17.0.0",
+    "@angular/core": "^18.2.5",
-    "@angular/forms": "^17.0.0",
+    "@angular/forms": "^18.2.5",
-    "@angular/material": "^17.3.1",
+    "@angular/material": "^18.2.5",
-    "@angular/platform-browser": "^17.0.0",
+    "@angular/platform-browser": "^18.2.5",
-    "@angular/platform-browser-dynamic": "^17.0.0",
+    "@angular/platform-browser-dynamic": "^18.2.5",
-    "@angular/router": "^17.0.0",
+    "@angular/router": "^18.2.5",
     "rxjs": "~7.8.0",
     "tslib": "^2.3.0",
-    "zone.js": "~0.14.2"
+    "zone.js": "~0.14.10"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "^17.0.5",
+    "@angular-devkit/build-angular": "^18.2.5",
-    "@angular/cli": "^17.0.5",
+    "@angular/cli": "^18.2.5",
-    "@angular/compiler-cli": "^17.0.0",
+    "@angular/compiler-cli": "^18.2.5",
-    "@angular/localize": "^17.3.12",
+    "@angular/localize": "^18.2.5",
     "@types/jasmine": "~5.1.0",
     "jasmine-core": "~5.1.0",
     "karma": "~6.4.0",
@@ -43,6 +43,6 @@
     "karma-coverage": "~2.2.0",
     "karma-jasmine": "~5.1.0",
     "karma-jasmine-html-reporter": "~2.1.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.5.4"
   }
 }

frontend/src/app/app.config.ts

@@ -1,4 +1,4 @@
-import { ApplicationConfig } from '@angular/core';
+import { ApplicationConfig, provideExperimentalZonelessChangeDetection } from '@angular/core';
 import { provideRouter, withRouterConfig } from '@angular/router';
 
 import { HTTP_INTERCEPTORS, provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
@@ -16,7 +16,9 @@ export const appConfig: ApplicationConfig = {
       })
     ), 
     provideAnimationsAsync(),
+    provideExperimentalZonelessChangeDetection(),
     provideHttpClient(withInterceptorsFromDi()),
+
     { provide: HTTP_INTERCEPTORS, useClass: JwtInterceptor, multi: true },
   ]
 };

frontend/src/app/components/side-menu/categories-menu/categories-menu.component.html

@@ -1,5 +1,5 @@
-@for(category of categories$ | async; track category) {
+@for(category of categories(); track category) {
-    <div class="category {{category.isOpenned ? 'openned' : ''}}">
+<div class="category {{category.isOpenned ? 'openned' : ''}}">
         <div id="category-{{category.id}}" class="category-header" (click)="setOpenned(category)">
             {{category.name}}
             <mat-icon>chevron_right</mat-icon>

frontend/src/app/components/side-menu/categories-menu/categories-menu.component.ts

@@ -1,9 +1,10 @@
 import { CommonModule } from "@angular/common";
-import { Component, EventEmitter, inject, OnInit, Output } from "@angular/core";
+import { Component, EventEmitter, inject, OnDestroy, OnInit, Output, signal } from "@angular/core";
 import { MatIconModule } from "@angular/material/icon";
 import { DisplayableCategory, SideMenuService } from "../side-menu.service";
-import { Observable } from "rxjs";
+import { Observable, Subscription } from "rxjs";
 import { RouterModule } from "@angular/router";
+import { Category } from "../../../core/rest-services/category/model/category";
 
 @Component({
 	selector: 'app-categories-menu',
@@ -12,17 +13,21 @@ import { RouterModule } from "@angular/router";
   templateUrl: './categories-menu.component.html',
   styleUrl: './categories-menu.component.scss'
 })
-export class CategoriesMenuComponent implements OnInit {
+export class CategoriesMenuComponent implements OnInit, OnDestroy {
-  private sideMenuService = inject(SideMenuService);
   @Output()
   categoryClicked = new EventEmitter<void>();
+  private sideMenuService = inject(SideMenuService);
+  private categoriesSubscription?: Subscription;
+  categories = signal<DisplayableCategory[]>([]);
 
   ngOnInit(): void {
+    this.categoriesSubscription = this.sideMenuService.categories$
+      .subscribe(categories => this.categories.set(categories));
     this.sideMenuService.loadCategories();
   }
 
-  get categories$(): Observable<DisplayableCategory[]> {
+  ngOnDestroy(): void {
-    return this.sideMenuService.categories$;
+    this.categoriesSubscription?.unsubscribe();
   }
 
   setOpenned(category: DisplayableCategory): void {

frontend/src/app/components/side-menu/side-menu.component.html

@@ -1,4 +1,4 @@
-<div class="menu {{ isOpenned ? 'displayed' : '' }}">
+<div class="menu {{ isOpenned() ? 'displayed' : '' }}">
     <h1>
         <a [routerLink]="['/home']">
             <img src="assets/images/codiki.png" alt="logo"/>
@@ -11,4 +11,4 @@
     <h2 i18n>Categories</h2>
     <app-categories-menu (categoryClicked)="close()"></app-categories-menu>
 </div>
-<div class="overlay {{ isOpenned ? 'displayed' : ''}}" (click)="close()"></div>
+<div class="overlay {{ isOpenned() ? 'displayed' : ''}}" (click)="close()"></div>

frontend/src/app/components/side-menu/side-menu.component.ts

@@ -1,4 +1,4 @@
-import { Component } from '@angular/core';
+import { Component, signal } from '@angular/core';
 import { MatIconModule } from '@angular/material/icon';
 import { MatTooltipModule } from '@angular/material/tooltip';
 import { RouterModule } from '@angular/router';
@@ -12,13 +12,13 @@ import { CategoriesMenuComponent } from './categories-menu/categories-menu.compo
   styleUrl: './side-menu.component.scss'
 })
 export class SideMenuComponent {
-  isOpenned: boolean = false;
+  isOpenned = signal(false);
 
   open(): void {
-    this.isOpenned = true;
+    this.isOpenned.set(true);
   }
 
   close(): void {
-    this.isOpenned = false;
+    this.isOpenned.set(false);
   }
 }

frontend/src/app/pages/home/home.component.html

@@ -1,5 +1,5 @@
 <h1 i18n>Last publications</h1>
-@if ((isLoading$ | async) === true) {
+@if (isLoading()) {
     <h2 i18n>Publications loading...</h2>
     <mat-spinner></mat-spinner>
 } @else {

frontend/src/app/pages/home/home.component.ts

@@ -1,6 +1,6 @@
-import { Component, OnInit, inject } from '@angular/core';
+import { Component, OnDestroy, OnInit, inject, signal } from '@angular/core';
 import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
-import { Observable } from 'rxjs';
+import { Observable, Subscription } from 'rxjs';
 import { PublicationListComponent } from '../../components/publication-list/publication-list.component';
 import { Publication } from '../../core/rest-services/publications/model/publication';
 import { HomeService } from './home.service';
@@ -18,18 +18,27 @@ import { CommonModule } from '@angular/common';
   styleUrl: './home.component.scss',
   providers: [HomeService]
 })
-export class HomeComponent implements OnInit {
+export class HomeComponent implements OnInit, OnDestroy {
   private homeService = inject(HomeService);
-
+  private isLoadingSubscription?: Subscription;
-  get isLoading$(): Observable<boolean> {
+  private publicationsSubscription?: Subscription;
-    return this.homeService.isLoading$;
+  isLoading = signal(false);
-  }
+  publicationsIsEmpty = signal(true);
 
   get publications$(): Observable<Publication[]> {
     return this.homeService.publications$;
   }
-
+  
   ngOnInit(): void {
+    this.isLoadingSubscription = this.homeService.isLoading$
+      .subscribe(isLoading => this.isLoading.set(isLoading));
+    this.publicationsSubscription = this.homeService.publications$
+      .subscribe(publications => this.publicationsIsEmpty.set(publications.length > 0));
     this.homeService.startLatestPublicationsRetrieving();
   }
+
+  ngOnDestroy(): void {
+    this.isLoadingSubscription?.unsubscribe();
+    this.publicationsSubscription?.unsubscribe();
+  }
 }

frontend/src/app/pages/my-publications/my-publications.component.html

@@ -8,11 +8,11 @@
     +
 </a>
 
-@if ((isLoading$ | async) === true) {
+@if (isLoading()) {
     <h2 i18n>Publication loading...</h2>
     <mat-spinner></mat-spinner>
 } @else {
-    @if ((isLoaded$ | async) === true) {
+    @if (isLoaded()) {
         <app-publication-list [publications$]="publications$"></app-publication-list>
     } @else {
         <h2 i18n>There is no any publication...</h2>

frontend/src/app/pages/my-publications/my-publications.component.ts

@@ -1,14 +1,13 @@
-import { Component, inject, OnInit } from "@angular/core";
+import { Component, inject, OnDestroy, OnInit, signal } from "@angular/core";
 import { MatProgressSpinnerModule } from "@angular/material/progress-spinner";
 import { MyPublicationsService } from "./my-publications.service";
-import { Observable } from "rxjs";
+import { Observable, Subscription } from "rxjs";
 import { PublicationListComponent } from "../../components/publication-list/publication-list.component";
 import { Publication } from "../../core/rest-services/publications/model/publication";
 import { CommonModule } from "@angular/common";
 import { RouterModule } from "@angular/router";
 import { MatTooltipModule } from "@angular/material/tooltip";
 
-
 @Component({
     selector: 'app-my-component',
     standalone: true,
@@ -23,22 +22,28 @@ import { MatTooltipModule } from "@angular/material/tooltip";
     ],
     providers: [MyPublicationsService]
 })
-export class MyPublicationsComponent implements OnInit {
+export class MyPublicationsComponent implements OnInit, OnDestroy {
     private readonly myPublicationsService = inject(MyPublicationsService);
+    private isLoadingSubscription?: Subscription;
+    private isLoadedSubscription?: Subscription;
+
+    isLoading = signal(false);
+    isLoaded = signal(false);
 
     get publications$(): Observable<Publication[]> {
         return this.myPublicationsService.publications$;
     }
 
-    get isLoading$(): Observable<boolean> {
-        return this.myPublicationsService.isLoading$;
-    }
-
-    get isLoaded$(): Observable<boolean> {
-        return this.myPublicationsService.isLoaded$;
-    }
-
     ngOnInit(): void {
+        this.isLoadingSubscription = this.myPublicationsService.isLoading$
+            .subscribe(isLoading => this.isLoading.set(isLoading));
+        this.isLoadedSubscription = this.myPublicationsService.isLoaded$
+            .subscribe(isLoaded => this.isLoaded.set(isLoaded));
         this.myPublicationsService.loadAuthenticatedUserPublications();    
     }
+
+    ngOnDestroy(): void {
+        this.isLoadingSubscription?.unsubscribe();
+        this.isLoadedSubscription?.unsubscribe();
+    }
 }

frontend/src/app/pages/publication-creation/publication-creation.component.html

@@ -1,7 +1,9 @@
-<app-publication-edition
+@if (publicationIsNotNull()) {
-    title="Creation of a new publication"
+    <app-publication-edition
-    [publication]="publication" 
+        title="Creation of a new publication"
-    [isSaving$]="isSaving$"
+        [publication]="publication()!!"
-    (publicationSave)="onPublicationSave($event)"
+        [isSaving$]="isSaving$"
-    i18n-title>
+        (publicationSave)="onPublicationSave($event)"
-</app-publication-edition>
+        i18n-title>
+    </app-publication-edition>
+}

frontend/src/app/pages/publication-creation/publication-creation.component.ts

@@ -1,4 +1,4 @@
-import { Component, inject, OnInit } from "@angular/core";
+import { Component, computed, inject, OnInit, signal } from "@angular/core";
 import { PublicationEditionComponent } from "../../components/publication-edition/publication-edition.component";
 import { PublicationRestService } from "../../core/rest-services/publications/publication.rest-service";
 import { ActivatedRoute, Router } from "@angular/router";
@@ -26,7 +26,8 @@ export class PublicationCreationComponent implements OnInit {
     private readonly snackBar = inject(MatSnackBar);
     private isSavingSubject = new BehaviorSubject<boolean>(false);
     private subscriptions: Subscription[] = [];
-    publication!: Publication;
+    publication = signal<Publication | undefined>(undefined);
+    publicationIsNotNull = computed(() => !!this.publication());
 
     get isSaving$(): Observable<boolean> {
         return this.isSavingSubject.asObservable();
@@ -40,7 +41,7 @@ export class PublicationCreationComponent implements OnInit {
                 name: authenticatedUser.pseudo,
                 image: authenticatedUser.photoId ?? ''
             };
-            this.publication = {
+            const newPublication: Publication = {
                 id: '',
                 key: '',
                 title: '',
@@ -52,6 +53,7 @@ export class PublicationCreationComponent implements OnInit {
                 categoryId: '',
                 author
             };
+            this.publication.set(newPublication);
         }
     }
 

frontend/src/app/pages/publication-update/publication-update.component.html

@@ -1,4 +1,4 @@
-@if ((isLoading$ | async) == true) {
+@if (isLoading()) {
     <h2 i18n>Loading publication to edit...</h2>
     <mat-spinner></mat-spinner>
 } 

frontend/src/app/pages/publication-update/publication-update.component.ts

@@ -1,5 +1,5 @@
 import { CommonModule, Location } from '@angular/common';
-import { Component, inject, OnDestroy, OnInit } from '@angular/core';
+import { Component, inject, OnDestroy, OnInit, signal } from '@angular/core';
 import { ReactiveFormsModule } from '@angular/forms';
 import { MatDialogModule } from '@angular/material/dialog';
 import { MatIconModule } from '@angular/material/icon';
@@ -41,21 +41,17 @@ export class PublicationUpdateComponent implements OnInit, OnDestroy {
   private readonly location = inject(Location);
   private readonly router = inject(Router);
   private readonly snackBar = inject(MatSnackBar);
-  private isLoadingSubject = new BehaviorSubject<boolean>(false);
   private isSavingSubject = new BehaviorSubject<boolean>(false);
   private subscriptions: Subscription[] = [];
+  isLoading = signal(false);
   publication: Publication | undefined;
 
-  get isLoading$(): Observable<boolean> {
-    return this.isLoadingSubject.asObservable();
-  }
-
   get isSaving$(): Observable<boolean> {
     return this.isSavingSubject.asObservable();
   }
 
   ngOnInit(): void {
-    this.isLoadingSubject.next(true);
+    this.isLoading.set(true);
     this.activatedRoute.paramMap.subscribe(params => {
         const publicationId = params.get('publicationId');
         if (publicationId == undefined) {
@@ -71,7 +67,7 @@ export class PublicationUpdateComponent implements OnInit, OnDestroy {
                 this.snackBar.open(errorMessage, $localize`Close`, { duration: 5000 });
                 console.error(errorMessage, error)
             })
-            .finally(() => this.isLoadingSubject.next(false));
+            .finally(() => this.isLoading.set(false));
         }
       });
   }

frontend/src/app/pages/publication/publication.component.html

@@ -1,14 +1,18 @@
-@if (isLoading) {
+@if (isLoading()) {
     <h2 i18n>Publication content loading...</h2>
     <mat-spinner></mat-spinner>
 } @else {
-    @if (publication) {
+    @if (isPublicationUndefined()) {
+        <div class="loading-failed">
+            <h1 i18n>Publication failed to load...</h1>
+        </div>
+    } @else {
         <div class="card">
-            <img src="/api/pictures/{{ publication.illustrationId }}" />
+            <img src="/api/pictures/{{ publication()?.illustrationId }}" />
             <header>
-                <h1>{{ publication.title }}</h1>
+                <h1>{{ publication()?.title }}</h1>
-                <h2>{{ publication.description }}</h2>
+                <h2>{{ publication()?.description }}</h2>
-                @if (isAuthorAndUserEquals) {
+                @if (isAuthorAndUserEquals()) {
                     <a [routerLink]="['edit']"
                         class="button action"
                         matTooltip="Click to edit the publication"
@@ -17,18 +21,18 @@
                     </a>
                 }
             </header>
-            <main [innerHTML]="publication.parsedText"></main>
+            <main [innerHTML]="publication()?.parsedText"></main>
             <footer>
                 <div class="metadata">
-                    <img src="/api/pictures/{{ publication.author.image }}" [matTooltip]="publication.author.name" />
+                    <img src="/api/pictures/{{ publication()?.author?.image }}" [matTooltip]="publication()?.author?.name" />
                     <div class="posting-data">
-                        <span i18n>Publication posted by {{ publication.author.name }}</span>
+                        <span i18n>Publication posted by {{ publication()?.author?.name }}</span>
                         <span class="publication-date">
-                            ({{ publication.creationDate | date: 'short' }})
+                            ({{ publication()?.creationDate | date: 'short' }})
                         </span>
                     </div>
                 </div>
-                @if (isAuthorAndUserEquals) {
+                @if (isAuthorAndUserEquals()) {
                     <button type="button"
                         (click)="deletePublication()"
                         matTooltip="Click to delete the publication" 
@@ -40,9 +44,5 @@
                 }
             </footer>
         </div>
-    } @else {
-        <div class="loading-failed">
-            <h1 i18n>Publication failed to load...</h1>
-        </div>
     }
 }

frontend/src/app/pages/publication/publication.component.scss

@@ -2,7 +2,8 @@ $cardBorderRadius: .5em;
 
 :host {
     display: flex;
-    justify-content: center;
+    flex-direction: column;
+    align-items: center;
 
     .card {
         display: flex;

frontend/src/app/pages/publication/publication.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnDestroy, OnInit, inject } from '@angular/core';
+import { Component, OnDestroy, OnInit, computed, inject, signal } from '@angular/core';
 import { PublicationRestService } from '../../core/rest-services/publications/publication.rest-service';
 import { ActivatedRoute, Router, RouterModule } from '@angular/router';
 import { Subscription } from 'rxjs';
@@ -30,9 +30,10 @@ export class PublicationComponent implements OnInit, OnDestroy {
   private readonly snackBar = inject(MatSnackBar);
   private paramMapSubscription?: Subscription;
   private afterDialogCloseSubscription?: Subscription;
-  isLoading: boolean = false;
+  isLoading = signal(false);
-  isAuthorAndUserEquals: boolean = false;
+  isAuthorAndUserEquals = computed(() => this.authenticationService.getAuthenticatedUser()?.id === this.publication()?.author.id);
-  publication?: Publication;
+  publication = signal<Publication | undefined>(undefined);
+  isPublicationUndefined = computed(() => !this.publication())
 
   ngOnInit(): void {
     this.paramMapSubscription = this.activatedRoute
@@ -41,12 +42,11 @@ export class PublicationComponent implements OnInit, OnDestroy {
           const publicationId = params.get('publicationId');
 
           if (publicationId) {
-            this.isLoading = true;
+            this.isLoading.set(true);
 
             this.publicationRestService.getById(publicationId)
                 .then(publication => {
-                  this.publication = publication;
+                  this.publication.set(publication);
-                  this.isAuthorAndUserEquals = this.authenticationService.getAuthenticatedUser()?.id === this.publication.author.id;
                   setTimeout(() => Prism.highlightAll(), 100);
                 })
                 .catch(error => {
@@ -55,7 +55,7 @@ export class PublicationComponent implements OnInit, OnDestroy {
                   console.error(errorMessage, error);
                 })
                 .finally(() => {
-                  this.isLoading = false;
+                  this.isLoading.set(false);
                 });
           }
         });
@@ -79,8 +79,8 @@ export class PublicationComponent implements OnInit, OnDestroy {
 
     this.afterDialogCloseSubscription = dialogRef.afterClosed()
       .subscribe(response => {
-        if (response && this.publication?.id) {
+        if (response && !this.isPublicationUndefined()) {
-          this.publicationRestService.delete(this.publication.id);
+          this.publicationRestService.delete(this.publication()?.id!!);
           this.snackBar.open($localize`Publication deleted`, $localize`Close`, { duration: 5000 });
           this.location.back();
         }